Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce :convert_dashes_to_underscores option #58

Merged
merged 1 commit into from
Mar 7, 2014
Merged

Introduce :convert_dashes_to_underscores option #58

merged 1 commit into from
Mar 7, 2014

Conversation

JanAhrens
Copy link
Contributor

Currently nori will automatically convert all dashes in tag names to underscores.

Nori.new.parse('<hello-world>Hi</hello-world>') # => " {"hello_world"=>"Hi"}

We want to use nori to test XML responses of our API. Some of our tag names contain dashes and some underscores. We would like to make the conversion behavior configurable.

This pull request introduces the :convert_dashes_to_underscores. It's enabled by default to not be a breaking change.

It's enabled by default to not be a breaking change.
tjarratt added a commit that referenced this pull request Mar 7, 2014
Introduce :convert_dashes_to_underscores option
@tjarratt tjarratt merged commit 88ed682 into savonrb:master Mar 7, 2014
@tjarratt
Copy link
Contributor

tjarratt commented Mar 7, 2014

Thanks for the PR! I've heard some grumblings about this recently, so it's nice to see some contributions and discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants