Merge 2a32906 into 9f48931

savonrb · Sep 13, 2017 · 1868a9f · 1868a9f
2 parents 9f48931 + 2a32906
commit 1868a9f
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 1 deletion.
diff --git a/lib/savon/qualified_message.rb b/lib/savon/qualified_message.rb
@@ -9,7 +9,7 @@ def initialize(types, used_namespaces, key_converter)
     end
 
     def to_hash(hash, path)
-      return unless hash
+      return hash unless hash
       return hash.map { |value| to_hash(value, path) } if hash.is_a?(Array)
       return hash.to_s unless hash.is_a?(Hash)
 

diff --git a/spec/savon/qualified_message_spec.rb b/spec/savon/qualified_message_spec.rb
@@ -62,6 +62,39 @@ module Savon
         expect(resulting_hash).to eq good_result
         expect(xml).to eq good_xml
       end
+
+      it "properly handles boolean false" do
+        used_namespaces = {
+          %w(tns Foo) => 'ns'
+        }
+
+        hash = {
+          :foo => {
+            :falsey => {
+              :@attr1 => false,
+              :content! => false
+            }
+          }
+        }
+
+        good_result = {
+          "ns:Foo" => {
+            :falsey => {
+              :@attr1 => false,
+              :content! => false
+            }
+          }
+        }
+
+        good_xml = %(<ns:Foo><Falsey attr1="false">false</Falsey></ns:Foo>)
+
+        message = described_class.new(types, used_namespaces, key_converter)
+        resulting_hash = message.to_hash(hash, ['tns'])
+        xml = Gyoku.xml(resulting_hash, key_converter: key_converter)
+
+        expect(resulting_hash).to eq good_result
+        expect(xml).to eq good_xml
+      end
     end
 
   end