added global :ssl_verify_mode options. fixes #297.

savonrb · Dec 19, 2012 · cd94583 · cd94583 · garcialopezco · Dec 21, 2012
1 parent dec5772
commit cd94583
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 2.0.2 (UPCOMING)
+
+* Fix: [#297](https://github.com/savonrb/savon/issues/297#issuecomment-11536517) added the global
+  `:ssl_verify_mode` option set the verify mode to use for SOAP requests.
+
 ## 2.0.1 (2012-12-19)
 
 * Fix [#342](https://github.com/savonrb/savon/issues/342) fixes an issue where namespaces could

diff --git a/lib/savon/options.rb b/lib/savon/options.rb
@@ -180,6 +180,11 @@ def last_response(last_response)
       @options[:last_response] = last_response
     end
 
+    # Whether and how to to verify the connection.
+    def ssl_verify_mode(verify_mode)
+      @options[:ssl_verify_mode] = verify_mode
+    end
+
     # HTTP basic auth credentials.
     def basic_auth(*credentials)
       @options[:basic_auth] = credentials.flatten

diff --git a/lib/savon/request.rb b/lib/savon/request.rb
@@ -48,6 +48,7 @@ def create_http_client
       http.headers["SOAPAction"] ||= %{"#{soap_action}"} if soap_action
       http.headers["Content-Type"] = CONTENT_TYPE[@globals[:soap_version]] % @globals[:encoding]
 
+      http.auth.ssl.verify_mode = @globals[:ssl_verify_mode] if @globals.include? :ssl_verify_mode
       http.auth.basic(*@globals[:basic_auth]) if @globals.include? :basic_auth
       http.auth.digest(*@globals[:digest_auth]) if @globals.include? :digest_auth
 

diff --git a/spec/savon/options_spec.rb b/spec/savon/options_spec.rb
@@ -255,6 +255,15 @@
     end
   end
 
+  context "global :ssl_verify_mode" do
+    it "sets the verify mode to use" do
+      HTTPI::Auth::SSL.any_instance.expects(:verify_mode=).with(:none)
+
+      client = new_client(:endpoint => @server.url, :ssl_verify_mode => :none)
+      client.call(:authenticate)
+    end
+  end
+
   context "global :basic_auth" do
     it "sets the basic auth credentials" do
       client = new_client(:endpoint => @server.url(:basic_auth), :basic_auth => ["admin", "secret"])