Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential memory leak #485

Closed
vanderhoorn opened this issue Jul 31, 2013 · 5 comments
Closed

Potential memory leak #485

vanderhoorn opened this issue Jul 31, 2013 · 5 comments

Comments

@vanderhoorn
Copy link

As you may know, while strings are garbage collected, symbols are not.

In the build_elements on line 27 all element names are symbolized (name.to_sym). So if you use the savon gem intensively in an application and you use a lot of different element names, the memory usage of the application will increase substantially over time. I don't think using symbols in this case is a wise approach.

@rubiii
Copy link
Contributor

rubiii commented Aug 2, 2013

your probably right. using symbols internally might not be necessary‎ and i have to look into that.

@raymondmars
Copy link

Hi, @rubiii , @vanderhoorn

This does cause memory leaks in our program, we have a program which will read a huge data from a webservice, when it run a day after it reached 8G memory footprint.

@rubiii
Copy link
Contributor

rubiii commented Aug 26, 2013

we can't change the symbols for version 2, but i'll make sure that version 3 doesn't cause such problems.

@vanderhoorn
Copy link
Author

No problem.

@rubiii rubiii mentioned this issue Nov 10, 2013
19 tasks
@tjarratt
Copy link
Contributor

Added a task for this in the version 3 TODO list #473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants