Document deprecation on :attributes! in favour of :@attr => ... in Savon 2

[skalarproduktraum]

I just figured out that the { :element => ..., :attributes! => { :element => {...}} syntax does not work anymore in Savon 2, seemingly due to changes in Gyoku. It'd be nice if that would be documented somewhere.

Using the {:element => { :@attrib => ...}} syntax works like a charm.

[tjarratt]

Thanks for pointing this out, @skalarproduktraum -- would you mind making a Pull Request on the docs if there's an area that covers that? Alternatively, this sounds like it might be an actual bug related to changes in gyoku, although I would be surprised if there wasn't a test for this in Savon...

Either way, this needs some investigation, and a failing test case would probably be useful for starters. Would you mind attaching a gist of something that fails to work as you expect?

[skalarproduktraum]

Hi @tjarratt, actually, there is no test in the v2 branch that uses attributes. I'm a bit in a hurry currently, but I'll prepare a test or gist later today or tomorrow. If it's no bug, it'd nevertheless be nice to document the changes, as this took me an awful lot of time to figure out :-/

[skalarproduktraum]

I finally managed to write a test for Savon 2, which makes a request (which is expected to fail) and captures the request sent, checking for absence of an <attributes> element. Find the test in https://github.com/skalarproduktraum/savon/blob/version2/spec/integration/centra_spec.rb

Sorry that the test for the new syntax is pending, I couldn't figure out why :(

[tjarratt]

Interesting, I'll have to take a further look into this when I get some time. I really appreciate you taking a look into this, @skalarproduktraum !

[tjarratt]

@skalarproduktraum I'm terribly sorry that it took me so long to take a look at this!

The tests you added are great, and exercise a rather critical part of Savon that hadn't really been tested in an integration environment yet, so I'd love if we could merge that into the 2.0 branch of Savon. Would you mind issuing a pull request?

[skalarproduktraum]

Hi there @tjarratt! Sorry for taking so long, I kinda missed the notification about your request :( I've finally submitted the pull request for the attribute test. Please let me know if there is something else I can do.

[tjarratt]

Cool, glad we could get that merged in :)