Add headers configuration to WSDLRequest#build #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please excuse the failing build. The failing test case seems to be failing on |
|
Please merge this, tested it and it works. |
|
Thanks. I'll merge this once I confirm the specs pass when rebased on master. Checking it out locally now. |
|
Thanks @janraasch for contributing this! |
|
Sure. Thank you for merging this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. some proxy servers may require
as part of the headers.
In particular we ran into issues with using the Proximo Heroku Add-On.
This fixes #750 and may be considered a late addition to #378.