CI: Travis maintenance: add JRuby 9.2; fix JRuby 9.1 build; configure Rubinius #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://travis-ci.org/github/savonrb/savon/jobs/580391898 was the failed job that I noted. |
olleolleolle
changed the title
|
@pcai Would you be comfortable with cutting out non-maintained Ruby versions? |
|
Thank you! Yes, I think we should cut unmaintained ruby. |
|
@pcai I'll continue doing that in this PR, if you 👍 it. In other words: Do you want this PR to remove the unmaintained Ruby versions from CI? In addition, would you want me to set the |
|
Nice work! |
|
@olleolleolle thanks. Yes if you open up another PR to update the gemspec then I will merge that too. IMO new releases should only be compatible with and tested for currently maintained versions of ruby. |
pcai
pushed a commit
that referenced
this pull request
Jul 5, 2020
… Rubinius (#921) * CI: Extend matrix w/ JRuby 9.2 * CI: run Rubinius in trusty * CI: JRuby 9.2 JAVA_OPTS with --add-opens decls See jruby/jruby#4834 * CI: Use "name" to identify specific matrix jobs * CI: Drop unmaintained Ruby versions - see https://www.ruby-lang.org/en/downloads/branches/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a CI change to use latest release of JRuby 9.1 (which is a 2.3, now out of support, see Ruby's support policy).
Did you add tests for your changes?
No, no new tests were added - this is a CI-only change.
Summary of changes
The attempt is: try to make the JRuby build pass.
allow_failuresallow_failuresCloses #910 by including its fix here.