Fix: Avoids an exception when presenting soap:Fault responses with invalid encoded chars #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
changed the title
olleolleolle
reviewed
Jul 5, 2020
| @@ -49,6 +49,11 @@ | |||
| it "returns false unless the HTTP response contains a SOAP fault" do | |||
| expect(Savon::SOAPFault.present? new_response).to be_falsey | |||
| end | |||
|
|
|||
| it "returns true if the HTTP response contains a SOAP fault with invalid ecoded char" do | |||
There was a problem hiding this comment.
Suggested change
| it "returns true if the HTTP response contains a SOAP fault with invalid ecoded char" do | |
| it "returns true even if the HTTP response contains a SOAP fault with invalid encoded characters" do |
There was a problem hiding this comment.
I added an even in order to underline that this is an additional condition that the code's able to handle.
|
Hi @lluis thank you for your contribution - do you mind rebasing/merging in master? Once the minor comments are addressed, I can merge and cut a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents "invalid byte sequence in UTF-8" exception when response has incorrectly encoded chars