gemspec: Require wasabi version that supports Ruby 3 #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Bugfix
Did you add tests for your changes?
No. There does not appear to be a way to test against different combinations of gems.
Summary of changes
Wasabi < 3.6 uses
URI.unescapewhich does not exist in Ruby 3. Wasabi does not test against Ruby 3 until v3.7, which is why the minimum is set to 3.7.#996
Other information
Recommend to patch 2.13 and 2.14 because they both support Ruby 3 according to the CI config.