Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff colors #12

Closed
lourenci opened this issue May 21, 2021 · 1 comment · Fixed by #14
Closed

Diff colors #12

lourenci opened this issue May 21, 2021 · 1 comment · Fixed by #14

Comments

@lourenci
Copy link

First of all, thanks for this colorscheme. I think it is one of the best dark themes out there, if not the best. It's all balanced. My coworkers always ask the name of it in a pair session. Please, make the palette more accessible for ports to other text editors. You did a great job here.

IMHO, this colorscheme fails just in one category: the diff colors. It's hard to tell what has changed at a glance.
I don't understand anything about colors, so I don't know what to suggest to help with this. Maybe, some background colors?

@savq
Copy link
Owner

savq commented May 23, 2021

First of all, thanks for this colorscheme

Thanks for using it!


About the diff colors, I agree that right now they don't look very good. I didn't put much thought into it. I'll see what other colorschemes are using, hopefully I'll find a useful convention.

I think Neovim will change the diff algorithm in the future, so that might help too.

savq added a commit that referenced this issue Jun 5, 2021
@savq savq closed this as completed in #14 Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants