Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of highlights for neotree #63

Conversation

gabrielmfern
Copy link
Contributor

@gabrielmfern gabrielmfern commented Jul 19, 2023

Checklist for Plugins

This PR adds highlights to the neo-tree.

  • (In colors/melange.lua) Add highlight groups
  • (In README.md) Add link to plugin source repository

Here is a screenshot I took showing off how the highlights I chose look:

Screenshot for neo-tree

Copy link
Owner

@savq savq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I'd be happy to take the changes for neo-tree. There's just a couple of things that need to get fixed.

On the other hand, if nvim-navic doesn't set any default highlight groups, I won't add support for that plugin. Forcing every color scheme to add support for a plugin, when the plugin could just set defaults, is counterproductive. I'd suggest you send a PR to them with these highlight links, so other color schemes can use them.

colors/melange.lua Outdated Show resolved Hide resolved
colors/melange.lua Outdated Show resolved Hide resolved
colors/melange.lua Outdated Show resolved Hide resolved
gabrielmfern and others added 2 commits August 7, 2023 06:16
Co-authored-by: Sergio A. Vargas <savargasqu+git@unal.edu.co>
@gabrielmfern gabrielmfern changed the title Implementation of highlights to navic and neotree Implementation of highlights and neotree Aug 7, 2023
@gabrielmfern
Copy link
Contributor Author

Thanks for the PR.

I'd be happy to take the changes for neo-tree. There's just a couple of things that need to get fixed.

On the other hand, if nvim-navic doesn't set any default highlight groups, I won't add support for that plugin. Forcing every color scheme to add support for a plugin, when the plugin could just set defaults, is counterproductive. I'd suggest you send a PR to them with these highlight links, so other color schemes can use them.

I think I agree with what you are saying about navic, just removed all references to it from the PR including in the code.

@gabrielmfern gabrielmfern changed the title Implementation of highlights and neotree Implementation of highlights for neotree Aug 7, 2023
@savq savq merged commit d412fbb into savq:master Aug 8, 2023
@savq savq mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants