-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of highlights for neotree #63
Implementation of highlights for neotree #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I'd be happy to take the changes for neo-tree. There's just a couple of things that need to get fixed.
On the other hand, if nvim-navic doesn't set any default highlight groups, I won't add support for that plugin. Forcing every color scheme to add support for a plugin, when the plugin could just set defaults, is counterproductive. I'd suggest you send a PR to them with these highlight links, so other color schemes can use them.
Co-authored-by: Sergio A. Vargas <savargasqu+git@unal.edu.co>
I think I agree with what you are saying about navic, just removed all references to it from the PR including in the code. |
Checklist for Plugins
This PR adds highlights to the neo-tree.
colors/melange.lua
) Add highlight groupsREADME.md
) Add link to plugin source repositoryHere is a screenshot I took showing off how the highlights I chose look: