align handling of graceful shutdown signals (#102)

* align handling of graceful shutdown signals * lint * added unit test --------- Co-authored-by: dan.markhasin <dan.markhasin@appsflyer.com>
savsgio · Jul 10, 2023 · 85d21a7 · 85d21a7
1 parent f81fcc6
commit 85d21a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/atreugo_unix.go b/atreugo_unix.go
@@ -21,6 +21,10 @@ func (s *Atreugo) ServeGracefully(ln net.Listener) error {
 		listenErr <- s.Serve(ln)
 	}()
 
+	if s.cfg.GracefulShutdown && len(s.cfg.GracefulShutdownSignals) == 0 {
+		s.cfg.GracefulShutdownSignals = append(s.cfg.GracefulShutdownSignals, defaultGracefulShutdownSignals...)
+	}
+
 	osSignals := make(chan os.Signal, 1)
 	signal.Notify(osSignals, s.cfg.GracefulShutdownSignals...)
 

diff --git a/atreugo_unix_test.go b/atreugo_unix_test.go
@@ -101,6 +101,10 @@ func TestAtreugo_ServeGracefully(t *testing.T) { // nolint:funlen
 				t.Errorf("Config.GracefulShutdown = %v, want %v", cfg.GracefulShutdown, true)
 			}
 
+			if len(s.cfg.GracefulShutdownSignals) == 0 {
+				t.Errorf("Config.GracefulShutdownSignals is empty, want %v", defaultGracefulShutdownSignals)
+			}
+
 			lnAddr := ln.Addr().String()
 			if s.cfg.Addr != lnAddr {
 				t.Errorf("Atreugo.Config.Addr = %s, want %s", s.cfg.Addr, lnAddr)