Adding UseFinal Middleware to Ensure Consistent HTTP Response Management

[shakedoron]

We have a situation where the Before middleware is returning an HTTP response.
Additionally, in the same service, we have an After middleware that we use to manage a metric of HTTP response status codes.
The current design does not support this case because the middleware chain is interrupted since the Before middleware returned an HTTP response, and we could not call ctx.next in this case.

In our implementation, we initially assumed that the after middleware would always be called.
For this case, and many others, we believe it is important to add middleware that will be called just before sending the HTTP response, without relying on what happened in the before, view, or after stages.

We decided not to use the existing middleware interface because it does not make sense for logic that runs at this stage to return an error since we did not want to change the ctx.Response based on these functions.
These functions should have logic that is separate from the existing logic for handling the request.

To solve the issue of HTTP responses being returned by Before middleware, we propose defining a new middleware method called UseFinal.
Any logic added to this middleware will be executed regardless of what happened in the before, view, or after stages, and will be called just before sending the HTTP response.

This approach will allow us to properly manage HTTP response status codes in all scenarios, without relying on the behavior of other middleware in the chain.
We believe this is a clean and effective solution that will improve the maintainability and scalability of our codebase.

[savsgio]

LGTM! I think it's a great solution, without break backward-compatibility and keeping the middleware semantics!

Thank you so much!

[coveralls]

Pull Request Test Coverage Report for Build 4895435820

• 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 4446681524:	0.0%
Covered Lines:	771
Relevant Lines:	771

---

💛 - Coveralls

[savsgio]

Can you fix the linter issues, please?

[shakedoron]

@savsgio Thanks for your fast response!
Happy to hear that you love our solution.

I fixed the linter issues :)
Let me know if it is ok now

[savsgio]

Thank you so much! @shakedoron