Skip to content

sawonorin/moneybox-withdrawal-master

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

5 Commits
 
 
 
 
 
 

Repository files navigation

Moneybox Money Withdrawal

The solution contains a .NET core library (Moneybox.App) which is structured into the following 3 folders:

  • Domain - this contains the domain models for a user and an account, and a notification service.
  • Features - this contains two operations, one which is implemented (transfer money) and another which isn't (withdraw money)
  • DataAccess - this contains a repository for retrieving and saving an account (and the nested user it belongs to)

The task

The task is to implement a money withdrawal in the WithdrawMoney.Execute(...) method in the features folder. For consistency, the logic should be the same as the TransferMoney.Execute(...) method i.e. notifications for low funds and exceptions where the operation is not possible.

As part of this process however, you should look to refactor some of the code in the TransferMoney.Execute(...) method into the domain models, and make these models less susceptible to misuse. We're looking to make our domain models rich in behaviour and much more than just plain old objects, however we don't want any data persistance operations (i.e. data access repositories) to bleed into our domain. This should simplify the task of implementing WithdrawMoney.Execute(...).

Guidelines

  • The test should take about an hour to complete, although there is no strict time limit
  • You should fork or copy this repository into your own public repository (Github, BitBucket etc.) before you do your work
  • Your solution must build and any tests must pass
  • You should not alter the notification service or the the account repository interfaces
  • You may add unit/integration tests using a test framework (and/or mocking framework) of your choice
  • You may edit this README.md if you want to give more details around your work (e.g. why you have done something a particular way, or anything else you would look to do but didn't have time)

Once you have completed test, zip up your solution, excluding any build artifacts to reduce the size, and email it back to our recruitment team.

Good luck!

My Notes

  • I did not implement repository as it is not stated. This impacted the test cases I could have written as below:
    1. Test for all errors that is thrown in the 2 methods.
    2. Other test for domain services and repositories.
  • I added a logger but assumed that the other initiation is done.
  • I introduced checking for transaction repetition within a specified time, 1 minute.

About

moneybox-withdrawal-master

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published

Languages