Skip to content

Commit

Permalink
add new test for issue #79
Browse files Browse the repository at this point in the history
  • Loading branch information
saxix committed Dec 8, 2015
1 parent 6c526bd commit e8297f8
Show file tree
Hide file tree
Showing 3 changed files with 123 additions and 0 deletions.
114 changes: 114 additions & 0 deletions docs/source/contributing.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
============
Contributing
============

Contributions are welcome, and they are greatly appreciated! Every
little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions
----------------------

Report Bugs
~~~~~~~~~~~

Report bugs at https://github.com/saxix/django-adminactions/issues.

If you are reporting a bug, please include:

* Your operating system name and version.
* Any details about your local setup that might be helpful in troubleshooting.
* Detailed steps to reproduce the bug.

Fix Bugs
~~~~~~~~

Look through the GitHub issues for bugs. Anything tagged with "bug"
is open to whoever wants to implement it.

Implement Features
~~~~~~~~~~~~~~~~~~

Look through the GitHub issues for features. Anything tagged with "feature"
is open to whoever wants to implement it.

Write Documentation
~~~~~~~~~~~~~~~~~~~

django-adminactions could always use more documentation, whether as part of the
official django-adminactions docs, in docstrings, or even on the web in blog posts,
articles, and such.

Submit Feedback
~~~~~~~~~~~~~~~

The best way to send feedback is to file an issue at https://github.com/saxix/django-adminactions/issues.

If you are proposing a feature:

* Explain in detail how it would work.
* Keep the scope as narrow as possible, to make it easier to implement.
* Remember that this is a volunteer-driven project, and that contributions
are welcome :)

Get Started!
------------

Ready to contribute? Here's how to set up `django-adminactions` for local development.

1. Fork the `django-adminactions` repo on GitHub.
2. Clone your fork locally::

$ git clone git@github.com:your_name_here/django-adminactions.git

3. Install your local copy into a virtualenv. Assuming you have virtualenvwrapper installed, this is how you set up your fork for local development::

$ mkvirtualenv django-adminactions
$ cd django-adminactions/
$ pip install -e .[dev]

4. Create a branch for local development::

$ git checkout -b name-of-your-bugfix-or-feature

5. Install your preferred Django version

$ pip install django

Now you can make your changes locally.

6. When you're done making changes, check that your changes pass flake8 and the
tests, including testing other Python versions with tox::

$ flake8 adminactions tests
$ py.test tests/
$ tox

7. Commit your changes and push your branch to GitHub::

$ git add .
$ git commit -m "Your detailed description of your changes."
$ git push origin name-of-your-bugfix-or-feature

7. Submit a pull request through the GitHub website.

Pull Request Guidelines
-----------------------

Before you submit a pull request, check that it meets these guidelines:

1. The pull request should include tests.
2. If the pull request adds functionality, the docs should be updated. Put
your new functionality into a function with a docstring, and add the
feature to the list in README.rst.
3. The pull request should work for Python 2.7, and 3.3, and for PyPy. Check
https://travis-ci.org/saxix/django-adminactions/pull_requests
and make sure that the tests pass for all supported Python versions.

Tips
----

To run a subset of tests::

$ py.test tests/<FILE>
1 change: 1 addition & 0 deletions docs/source/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Table Of Contents
:maxdepth: 1

install
contributing
actions
signals
exceptions
Expand Down
8 changes: 8 additions & 0 deletions tests/test_permissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import pytest
from django.core.urlresolvers import reverse
from demo.utils import user_grant_permission
from django.contrib.auth.models import Permission


logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -41,3 +43,9 @@ def test_permission_needed(app, admin, demomodels, action):
user=admin.username,
expect_errors=True)
assert res.status_code == 200

@pytest.mark.django_db
def test_permissions(admin):
assert Permission.objects.filter(codename__startswith='adminactions').count() == 32
with user_grant_permission(admin, ['demo.adminactions_export_demomodel']):
admin.get_all_permissions() == set([u'demo.adminactions_export_demomodel'])

0 comments on commit e8297f8

Please sign in to comment.