Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple UI xplr like ranger #107

Closed
ghost opened this issue Apr 25, 2021 · 8 comments · Fixed by #125
Closed

Simple UI xplr like ranger #107

ghost opened this issue Apr 25, 2021 · 8 comments · Fixed by #125

Comments

@ghost
Copy link

ghost commented Apr 25, 2021

First Thanks for develop
Please make default UI simple like python/ranger and for TUI it's use config or something like xplr -s --simple as simple ui
simple ui -> xplr without selection,help section and maybe remove borders!
at the end, sorry for my bad English :)

@sayanarijit
Copy link
Owner

Hey, thanks for your feedback. I'll see how I can provide more UI options without losing its strong points.

@aecepoglu
Copy link

Being able to close panels from the config should be an easy start and something I'd like to be able to do

@sayanarijit
Copy link
Owner

I thought about this and came up with this idea:

  • We should be able to define the xplr UI layout via the config file.
  • A layout can contain either a Vertical split, or a Horizontal split, or a leaf node.
  • Each (Vertical and Horizontal) split can have their own nested layouts.
  • The leaf nodes will be the panels e.g. Table, SortNFilter, InputOrLog, Selection etc.
  • Each layout size can be adjusted via config.

@aflyingpumpkin
Copy link
Contributor

Another feature that could be added is different UI modes. Which would allow the creation of modes for preview (if and when it is implemented) , Simple UI, and for the normal UI.

@sayanarijit
Copy link
Owner

sayanarijit commented May 4, 2021

So just like we have mode:, we can have

layout:
  builtin:
    default:
    ...
  custom:
    custom_layout1:
    ...

Then we can switch between layouts with SwitchLayout: default, SwitchLayout: custom_layout1.

@maximbaz any feedback?

Speaking of modes, I'm also thinking about introducing 2 new messages SwitchModeBuiltin: {mode} and SwitchModeCustom: {mode} so that we can be more specific about which mode to switch to. The same can be done for the layout.

@maximbaz
Copy link
Contributor

maximbaz commented May 4, 2021

This sounds very powerful! I like the idea with file preview, I also wonder if people from the mc will appreciate this to make a dual-panel file manager, if this will be allowed :)

@sayanarijit
Copy link
Owner

I don't think we can use the layout feature to manage multiple xplr sessions. It will complicate things. Bit yes, when we implement cli options, it will be helpful to be able to spawn new xplr sessions with hidden selection and help menu panels.

sayanarijit added a commit that referenced this issue May 7, 2021
Also, use a better prompt symbol.

Ref: #107
sayanarijit added a commit that referenced this issue May 7, 2021
Also, use a better prompt symbol.

Ref: #107
sayanarijit added a commit that referenced this issue May 7, 2021
Also, use a better prompt symbol.

Ref: #107
sayanarijit added a commit that referenced this issue May 7, 2021
Also, use a better prompt symbol.

Ref: #107
sayanarijit added a commit that referenced this issue May 7, 2021
Also, use a better prompt symbol.

Ref: #107
sayanarijit added a commit that referenced this issue May 7, 2021
Now, users can change the UI layout via the `SwitchLayout{Builtin|Custom}`
message, or by using key `ctrl-w`.

There are 3 default layout options -

- default
- no_help
- no_selection
- no_help_no_selection

Also, the initial mode and the initial layout can be specified in the
config.

Closes: #107
@sayanarijit
Copy link
Owner

^ Finally, PR ready for review.

sayanarijit added a commit that referenced this issue May 8, 2021
Now, users can change the UI layout via the `SwitchLayout{Builtin|Custom}`
message, or by using key `ctrl-w`.

There are 3 default layout options -

- default
- no_help
- no_selection
- no_help_no_selection

Also, the initial mode and the initial layout can be specified in the
config.

Closes: #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants