Auto disown when opening in gui

[aflyingpumpkin]

Upon opening an application in gui the current terminal window is still linked to the gui. Meaning that I cannot close it without it closing the GUI. I am also locked out of the current xplr session. Meaning I cannot browse other files after opening a single file. Upon closing the GUI application the GUI for xplr becomes messed up. (view attached image.)

[sayanarijit]

You can use ctrl-r to reset the screen. Or terminal resize should also work.

[sayanarijit]

@aflyingpumpkin let me know if ^ this works.

[aflyingpumpkin]

@aflyingpumpkin let me know if ^ this works.
This does resolve the buggy visuals open closing a gui. Though I still can't use xplr while a GUI application is open.

[sayanarijit]

Should solve. I can't can test it now because my window manager will autoresize the screen which causes the refresh automatically.

[sayanarijit]

CTRL+R doesn't solve it? Can you pls provide more info like which OS, window manager, terminal are you using?
A gif would be awesome.

[aflyingpumpkin]

My window manager (dwm) also resizes the window upon closing the GUI. But I believe the GUI the process is not completely terminated when the window resizes which causes the buggy visuals. Also, I am locked out of xplr when the gui is open.

[sayanarijit]

Have you tried other terminals?

[aflyingpumpkin]

Just tried in Alacritty and the issue still persists.

[sayanarijit]

Which application are you trying to open?

[sayanarijit]

If I run xdg-open x.doc, it opens in Kate and works fine.

[sayanarijit]

Just FYI this command is being executed.

[sayanarijit]

${OPENER:-open} "${XPLR_FOCUS_PATH:?}" &> /dev/null &

This might solve the issue but need to test it. @aflyingpumpkin can you try overwriting the command?

[aflyingpumpkin]

${OPENER:-open} "${XPLR_FOCUS_PATH:?}" &> /dev/null & disown -h
Fixes my issue though it does cause some text to be displayed on xplr when opening prior to window resize

[aflyingpumpkin]

is the text that appears

[sayanarijit]

And ctrl+r doesn't fix it?

[aflyingpumpkin]

ctrl+r fixes it, and it usually goes away when the application is opened unless I am in fullscreen mode.

[sayanarijit]

Hmm... not sure how to workaround this without a proper testing environment. @aflyingpumpkin if possible, can you pls create a PR?

[aflyingpumpkin]

What is a PR?

[sayanarijit]

A pull request with the fix. No problem, I can do this.

[aflyingpumpkin]

Just found out that the random text was due to me accidentally putting:
OPENER="$(which xdg-open $)"
instead of
OPENER="$(which xdg-open)"

[sayanarijit]

Ah ok.. Unfortunately the disown hack is causing other side effects. After I exit the session, the terminal session is messed up if there are disowned jobs. I think we need to investigate more into this.

[sayanarijit]

Nope, that was my fault. I used disown incorrectly and didn't exit the terminal.

[aflyingpumpkin]

I found an issue with the disown hack. If xplr is still open and the terminal is terminated the gui will also be terminated.

[sayanarijit]

Weird... Not in my WM...

[sayanarijit]

I'll setup a test VM with dwm when I get some time. Meanwhile, @aflyingpumpkin you can experiment with different command combinations and let me know if you find anything that works.

[sayanarijit]

Although if it's too hacky, we'll probably need to report the issue to DWM maintainers.

[maximbaz]

I got a ping on the (now closed) PR, to be honest I can't reproduce the issue on latest main (kitty, sway, arch) - i can open multiple files using gx, I can then close xplr, close terminal, and all gui app will remain and will function properly 🤷‍♂️

[maximbaz]

What's your $OPENER? I recently discovered that xdg-open is quite weird sometimes, after I forced it to be an alias to gio open my life became so much better and random bugs just went away. Could it be this case too? 🤔

My solution was to simply create an executable script called ~/.local/bin/xdg-open with the contents below (assuming ~/.local/bin is first in $PATH):

#!/bin/sh

gio open "$@"

Maybe worth a try for you too? Do this, open new terminal, double check that which xdg-open now points to it, and then retry.

[aflyingpumpkin]

I am using xdg-open, after doing a force alias the bug still persists.

[aflyingpumpkin]

I think it may be a problem with disown. Currently only having the & symbol is needed, and disown -h should block the termination signal from doing anything.

[sayanarijit]

@aflyingpumpkin I was using plain disown, not disown -h.

[sayanarijit]

Try this: https://github.com/sayanarijit/xplr/pull/109/files

[aflyingpumpkin]

I saw, even when I use what was put in the pull request the issue still exists.

[sayanarijit]

Maybe it's WM specific bug? Need to test it on different window managers. So far as we know,

KDE + KWin -> Working
SWAY (I3) -> Working
DWM -> Broken
GNOME -> Not tested
XFCE -> Not tested
I3 (stock) -> Broken
I3-status -> Not tested
BSPWM -> Not tested
AwesomeWM -> Not tested
qtile -> Not tested
xmonad -> Not tested

[aflyingpumpkin]

I have tried stock i3 and it appears to be broken.

[sayanarijit]

I wish I had more users in our discord channel, then I could just ping users to test report this 😄

[aflyingpumpkin]

Just tried kwin with alacritty and kitty and I am still running into the issue. I also tried switching to zsh and I am still running into the issue.

[sayanarijit]

Wow, then it seems more like a platform issue? Which OS are you using?

[aflyingpumpkin]

I use arch btw

[sayanarijit]

And maybe shell?

[aflyingpumpkin]

I tried on both zsh and bash.

[sayanarijit]

Very strange. I'm out of ideas. Can you record a video? I think GitHub allows posting video files.

[sayanarijit]

GitHub broke 😄

[aflyingpumpkin]

No, I deleted the message because the aspect ratio was messed up.
https://user-images.githubusercontent.com/49350251/116135449-28d52400-a69f-11eb-9664-f58095b81292.mp4

[sayanarijit]

@aflyingpumpkin you can maybe also capture a GIF using https://github.com/phw/peek. Preferably the KDE-Kwin one.

[sayanarijit]

No, I deleted the message because the aspect ratio was messed up.
https://user-images.githubusercontent.com/49350251/116135449-28d52400-a69f-11eb-9664-f58095b81292.mp4

Runs on VLC

[sayanarijit]

It the video xplr seems to work fine? You opened the file, then closed xplr?

[aflyingpumpkin]

The first example where they both closed at the same time was when I left xplr open and closed the terminal. The second example when the document stayed open was due to the fact that I fist closed xplr then closed the terminal.

[sayanarijit]

Ah okay, so that's what you meant.

[sayanarijit]

Yes I can reproduce this. I don't think you're supposed to close the terminal before quitting xplr gracefully.

[sayanarijit]

The document will stay open. You close it separately. It's the expected behavior I guess.

[sayanarijit]

Or, if you want to open multiple documents, you can do so, but you need to close them manually and quit xplr gracefully.

[sayanarijit]

You can probably achieve what you want to, using nohup or screen or tmux. But I don't think it should be the default in xplr.

[aflyingpumpkin]

Alright, thanks

[sayanarijit]

@aflyingpumpkin v0.9.1 probably fixed the issue in a way you wanted. You can close the terminal after opening apps in GUI, without closing them.

[aflyingpumpkin]

Great!