Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the key bindings further (add reckless mode) #142

Closed
sayanarijit opened this issue May 12, 2021 · 4 comments · Fixed by #143
Closed

Improve the key bindings further (add reckless mode) #142

sayanarijit opened this issue May 12, 2021 · 4 comments · Fixed by #143

Comments

@sayanarijit
Copy link
Owner

I like the key binding changes introduced in e0f8207 so much that I'm now considering an even stricter behavior, where an invalid key press will take you to a mode where the only keys you can use will be esc to escape the mode and ctrl-c to quit the app. This will save you from yourself when you're going too fast, recklessly.

Comments? @maximbaz

@maximbaz
Copy link
Contributor

Hmmmm certainly an interesting idea, but I'm not sure if it will be more useful or annoying 🤔
But the more I think about it, the more I like.

Are you thinking even in default mode? So if I hit n instead of j to go down, then I need to esc before I can hit j?

It most certainly happened to me, not only in xplr, that for example I wanna search for asdf, I think I press / but I miss it, and then I type out the entire search term, wreaking havoc, only to realize that I didn't enter the search mode. With the strict mode, I can still be unlucky that my search term will match some existing keys, but if at least one of them is invalid, I'd be saved by the fail mode.

@sayanarijit
Copy link
Owner Author

I'll create a similar proof of concept PR to test it out.

@sayanarijit sayanarijit changed the title Improve the key bindings further Improve the key bindings further (add reckless mode) May 12, 2021
sayanarijit added a commit that referenced this issue May 12, 2021
Pressing an invalid key will take you to the "reckless" mode. All you
need to do is calm down, escape that mode, and try again.

Closes: #142
@sayanarijit
Copy link
Owner Author

I think itll work best with a disable option.

@sayanarijit
Copy link
Owner Author

Are you thinking even in default mode? So if I hit n instead of j to go down, then I need to esc before I can hit j?

Yes

sayanarijit added a commit that referenced this issue May 13, 2021
Pressing an invalid key will take you to the "reckless" mode. All you
need to do is calm down, escape that mode, and try again.

Closes: #142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants