Pattern matching in node_type

[RustemB]

for exampe

xplr.config.node_types.mime_essence = {
	["video/*"] = {
		meta = { icon = "📽" },
	}
}

to match all video types

[sayanarijit]

Pattern matching might be a little difficult to implement and might have performance costs. But I think it'll be possible to implement nested mime types.

E.g.

video = {
  default = ...
  mp4 = ...
}

[bew]

I'm curious, what would be difficult to implement here?

As for performance, have you considered a cache, to search only once the settings for a given mime type, and always use the same on subsequent needs?

[sayanarijit]

Going through the keys and matching patterns efficiency.

From O(1) it becomes O(n)

[sayanarijit]

I'm curious, what would be difficult to implement here?

As for performance, have you considered a cache, to search only once the settings for a given mime type, and always use the same on subsequent needs?

Sounds cool. Can you please provide a minimal prototype implementation for xplr?

[bew]

Not anytime soon, I'm a Rust beginner who happen to have a few ideas from times to times, but not enough time to do them ATM. 👀

My comment was mainly to give an idea in case you didn't thought about it, but I won't contribute code for now

[sayanarijit]

No issues 👍
And thanks for the suggestion. I'll keep it in mind.

[sayanarijit]

Going with the no-pattern matching logic.

You can defing mime types like

xplr.config.node_types.mime_essence["video"] = {
  ["*"] = {
    meta = { icon = "📽" },
  }
}

[sayanarijit]

I think the issue is solved. Hence closing this.