Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --locked when releasing #212

Closed
sayanarijit opened this issue Jun 3, 2021 · 1 comment · Fixed by #215
Closed

Use --locked when releasing #212

sayanarijit opened this issue Jun 3, 2021 · 1 comment · Fixed by #215

Comments

@sayanarijit
Copy link
Owner

I'd also recommend using this flag in CI, for consistency :)

Originally posted by @maximbaz in #208 (comment)
sayanarijit added a commit that referenced this issue Jun 4, 2021
@sayanarijit
Use --locked when releasing
f54a187 
Closes: #212
@sayanarijit sayanarijit mentioned this issue Jun 4, 2021
Merged
sayanarijit added a commit that referenced this issue Jun 4, 2021
@sayanarijit
Use --locked when releasing
81854b9 
Closes: #212
@sayanarijit
Copy link
Owner Author

sayanarijit commented Jun 5, 2021 •
edited
Loading

Probably need to remove --locked because many crates are outdated.

@sayanarijit sayanarijit reopened this Jun 5, 2021
sayanarijit added a commit that referenced this issue Jun 5, 2021
@sayanarijit
Remove --locked
df2ae2d 
Many crates are outdated. One is even yanked. IMO failing build is
better than running with insecure/bad dependencies.

Ref: #212 (comment)
@sayanarijit sayanarijit mentioned this issue Jun 5, 2021
Merged
sayanarijit added a commit that referenced this issue Jun 5, 2021
@sayanarijit
Remove --locked
a1a1dee 
Many crates are outdated. One is even yanked. IMO failing build is
better than running with insecure/bad dependencies.

Ref: #212 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use --locked when releasing sayanarijit/xplr
1 participant
@sayanarijit