Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FocusNext and FocusPrevious #253

Closed
sayanarijit opened this issue Jun 9, 2021 · 0 comments · Fixed by #261
Closed

Improve FocusNext and FocusPrevious #253

sayanarijit opened this issue Jun 9, 2021 · 0 comments · Fixed by #261
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sayanarijit
Copy link
Owner

As discussed in this thread we can improve the FocusNext and FocusPrevious behavior by making them loop, i.e. instead of stopping at the 0th or nth index, the focus can continue scrolling assuming (0 - 1 = n) and (n + 1 = 0) where n is the last index.

Other messages like *ByRelativeIndex will retain their original behavior.

@sayanarijit sayanarijit added good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jun 9, 2021
sayanarijit added a commit that referenced this issue Jun 16, 2021
sayanarijit added a commit that referenced this issue Jun 16, 2021
sayanarijit added a commit that referenced this issue Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant