Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SelectPath resolve paths to (symlink) absolute paths #255

Closed
sayanarijit opened this issue Jun 11, 2021 · 0 comments · Fixed by #260
Closed

Make SelectPath resolve paths to (symlink) absolute paths #255

sayanarijit opened this issue Jun 11, 2021 · 0 comments · Fixed by #260

Comments

@sayanarijit
Copy link
Owner

sayanarijit commented Jun 11, 2021 •
edited

External tools like fzf, dua-cli etc. can return relative paths instead of absolute paths.
Let's resolve the paths to their (symlink) absolute paths when selecting using SelectPath.

Do not select paths if resolution fails. Display errors instead.

Use case:

  • Improve the dua-cli hack, so that there's to need to execute realpath.
sayanarijit added a commit that referenced this issue Jun 16, 2021
@sayanarijit
Fix handling of relative paths
9c68c93 
Closes: #255
@sayanarijit sayanarijit mentioned this issue Jun 16, 2021
Merged
sayanarijit added a commit that referenced this issue Jun 16, 2021
@sayanarijit
Fix handling of relative paths
4d8f1ef 
Closes: #255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of relative paths sayanarijit/xplr
1 participant
@sayanarijit