Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should selection be a set, to prevent duplicates? #81

Closed
maximbaz opened this issue Apr 18, 2021 · 2 comments · Fixed by #83
Closed

Should selection be a set, to prevent duplicates? #81

maximbaz opened this issue Apr 18, 2021 · 2 comments · Fixed by #83

Comments

@maximbaz
Copy link
Contributor

  • Pressing Ctrl+a multiple times adds the same time multiple times
  • After selecting a few files with space, and then selecting with Ctrl+a will also add duplicates

If we keep selection in a "set" structure, it should automatically take care of duplicates. Question is, is it a good idea, or will this break some scenarios?
sayanarijit added a commit that referenced this issue Apr 18, 2021
@sayanarijit
Fix selection
2baf2c9 
Fixes: #81
@sayanarijit sayanarijit mentioned this issue Apr 18, 2021
Merged
@sayanarijit
Copy link
Owner

Yes. I was actually waiting for something to force me into using IndexSet external library.

sayanarijit added a commit that referenced this issue Apr 18, 2021
@sayanarijit
Fix selection
98338c7 
Fixes: #81
@sayanarijit
Copy link
Owner

But then I included it, I forgot to port the selection to this.

sayanarijit added a commit that referenced this issue Apr 18, 2021
@sayanarijit
Fix selection
e70fa57 
Fixes: #81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix selection sayanarijit/xplr
2 participants
@maximbaz @sayanarijit