Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Vim-Like Scrolling to XPLR #704

Merged
merged 14 commits into from
Apr 10, 2024
Merged

Adds Vim-Like Scrolling to XPLR #704

merged 14 commits into from
Apr 10, 2024

Conversation

ElSamhaa
Copy link

@ElSamhaa ElSamhaa commented Apr 7, 2024

  • Added through a setting vimlike_scrolling which is turned off by default
  • A hard-coded (for now) cushion of 5 lines that allows for previewing the next lines while scrolling
  • A separate struct ScrollState with getters and setters for the current_focus field to disallow setting the field without updating the last_focus field

@sayanarijit
Copy link
Owner

Wow… thanks for pr. I’ll review soon.

@ElSamhaa
Copy link
Author

ElSamhaa commented Apr 8, 2024

  • An initial cushion value is now set to 5. The cushion value is now dynamically set to accommodate small view ports (table heights).

@sayanarijit
Copy link
Owner

I wanted to avoid mutable state in UI code, but looks like it's worth the tradeoff.

@sayanarijit sayanarijit merged commit c1bb251 into sayanarijit:dev Apr 10, 2024
10 checks passed
sayanarijit added a commit that referenced this pull request May 1, 2024
sayanarijit added a commit that referenced this pull request May 1, 2024
This was referenced May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants