Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas Id #207

Open
Paulsky opened this issue Sep 11, 2017 · 3 comments
Open

Canvas Id #207

Paulsky opened this issue Sep 11, 2017 · 3 comments

Comments

@Paulsky
Copy link

Paulsky commented Sep 11, 2017

Hello,

I want to position the canvas element myself. I read in the Readme that I should use '<canvas id="x"></canvas>' in combination with <ng-pdf canvasid="x"></ng-pdf>.

But that’s not working. When I’m looking in the source code, I can see how the canvas is created: 'var canvas = $document[0].createElement('canvas');'.

But I can’t find anything in the code that checks for canvasid or if there is an existing canvas. Could you please help me? Or maybe update the readme?

@mateoSerna
Copy link

Same problem here

@jegjessing
Copy link

I too have this issue. Any solution for this soon?
I'd like not to modify the source.

Should/could I modify the source and commit it here?

@dennybiasiolli
Copy link
Collaborator

Yes @jegjessing , you can modify the source, PR's are welcome!

JochenRousse pushed a commit to JochenRousse/angularjs-pdf that referenced this issue Feb 28, 2018
This fix aims to restore the functionality of being able to position
the canvas element using the canvasid attribute.
JochenRousse pushed a commit to JochenRousse/angularjs-pdf that referenced this issue Mar 1, 2018
This fix aims to restore the functionality of being able to position
the canvas element using the canvasid attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants