Correctly handle success-but-no-content responses #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparentlymart
added a commit
that referenced
this pull request
Dec 19, 2011
Correctly handle success-but-no-content responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several success response codes that are listed as False in HttpObject.response_has_content: 202 Accepted and 204 No Content. Currently HttpObject.update_from_response does not respect response_has_content, and so if it actually receives a non-error response without body content, it results in a ValueError "No JSON object could be decoded."
These changes add a test for that case, and fix it, by simply not trying to update data from a response that is not expected to contain content.