Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game now continues to crash after building an array of trays to farm food items #3496

Closed
HugKitten opened this issue Aug 16, 2023 · 8 comments

Comments

@HugKitten
Copy link

HugKitten commented Aug 16, 2023

Crashes on both proton compatibility mode (linux compatibility layer), and starbound native (Native build for linux). Had hours of play time where things worked fine up into this point.
List of mods
Storage folder
starbound.log

Steps to reproduce

  1. Download the mods
  2. Add storage files and folders into your starbound storage directory
  3. Create a new save, and enter the game, eventually making your choice of BYOS starter ships
  4. Observe that the game does not crash and seems to not have any issues
  5. Logout of that character and play using the last played Sarah character (The neko race one)
  6. Observe the game run fine for about a second before freezing and eventually crashing.
@HugKitten
Copy link
Author

HugKitten commented Aug 16, 2023

Adding return on the line after growPlant in isn_unifiedgrowingtray.lua causes it to no longer crash. Seems something is causing the game to crash here?

@HugKitten
Copy link
Author

After some debugging, I must have done something to fix the state, because my current save does not have this issue.

@Kherae
Copy link
Collaborator

Kherae commented Aug 18, 2023

insufficient detail, need more info. what was in the trays? 'line after growplant' which one? the function declaration on line 253, or when it's called on line 87?
I'm not inclined toward downloading all of your mods to test this, nor am I going to download your 400 megabyte storage folder.

@HugKitten
Copy link
Author

HugKitten commented Aug 20, 2023

It was a 10x10 array of trays with seeds and the likes in them. I was referring to the function not the call. I seem to be getting the bug again after extending my storage network.
Here's the log file from the crash.

@Kherae
Copy link
Collaborator

Kherae commented Aug 20, 2023

sb.logInfo("growPlant:fu_sendOrStoreItems 1: %s",{item=item, name1 = item.name, name2 = storage.currentseed.name, seedavoid = seedavoid, inputslots = inputSlots})
put this preceeding the following in the growplant function
fu_sendOrStoreItems(0, item, item.name == storage.currentseed.name and seedavoid or inputSlots)

do the same at the next sendorstore call with these:
sb.logInfo("growPlant:fu_sendOrStoreItems 2: %s",{currentseed = storage.currentseed, seedavoid = seedavoid})
placed above
fu_sendOrStoreItems(0, storage.currentseed, seedAvoid)

play with these til you get a crash, provide another log

@HugKitten
Copy link
Author

HugKitten commented Aug 20, 2023

It seems it crashes before hitting any of the logs. I uncommented the the other loginfo calls to show that it was still logging properly:
isn_unifiedgrowingtray.lua
starbound.log (Proton)
starbound.log (Linux Native)

@HugKitten
Copy link
Author

HugKitten commented Aug 20, 2023

This may be an issue with the storage network not with trays. I am not familiar enough with modding to determine if that is the case. It appears that this person is having the same issue I am.

Edit:
It seems putting return; after "function growPlant(growthmod, dt)" causes it to not crash. I was messing with the storage network (not the trays) so I am not sure if this is an issue with trays or just the storage network.

@Kherae
Copy link
Collaborator

Kherae commented Aug 26, 2023

very unlikely it's item network code. if your touching the trays is causing it to not error, that means it's doing something with items that the engine doesnt like. and i'm honestly surprised you havent tried the 'brute force trace' approach...add a log printout before every damn statement in the growplant function (with different text). so...go try that for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants