Add a parameter allowing avoidance of automatic service restarts after configuration changes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2014 12:47
|
Could you please rebase your pull request so I'm able to merge it directly? Additional points for extending the spec tests! |
|
Actually it make sense to restart memcache every time configuration changes. But the way it is done in this pull request is not clean. All you need to do is notify the service. Probably will create new pull request with the reference to this one. |
This was referenced Mar 9, 2014
|
pull request is done. Feel free to ping me if you need anything else |
|
Thinking about this, if I'm installing memcached the first time, e.g. on Debian, it gets started. Changing the config now, will not trigger a service restart if it's set to false and the new config won't be used. Am I wrong? |
|
Any comments? |
|
Please re-open, if still required. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're cloud based and often find it better to switch to a new cluster of memcached servers rather than allowing memcached to restart after a configuration change. This new parameter defaults to true maintaining current behavior.