add support for client "match blocks" #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
force-pushed
the
IT-3497/client_match_block
branch
3 times, most recently
from
91fa362
to
05832a2
Compare
|
I've rebased on current I'll also note that the rspec coverage of the |
|
saz
requested changes
Apr 27, 2022
Uh... I seem to be insane. Please ignore that comment. |
jhoblitt
force-pushed
the
IT-3497/client_match_block
branch
from
05832a2
to
3ccb1fb
Compare
|
@saz ping? |
saz
approved these changes
May 31, 2022
jhoblitt
added a commit
to lsst-it/saz-puppet-ssh
that referenced
this pull request
Jun 29, 2022
In the client match block support added via saz#332, I had not correctedly interpreted `ssh_config(5). A match block is negated by prepending a ! to the match type, not the parameters to the match type. Per the man page: Criteria may be negated by prepending an exclamation mark (‘!’).
jhoblitt
added a commit
to lsst-it/saz-puppet-ssh
that referenced
this pull request
Jun 29, 2022
In the client match block support added via saz#332, I had not correctly interpreted `ssh_config(5). A match block is negated by prepending a ! to the match type, not the parameters to the match type. Per the man page: Criteria may be negated by prepending an exclamation mark (‘!’).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rspec tests are limited in an attempt to avoid merge conflicts with #331.