OpenBSD compatibility. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -3,6 +3,8 @@ | |||
| setcode do | |||
| if Facter::Util::Resolution.which('rpm') | |||
| sudoversion = Facter::Util::Resolution.exec('rpm -q sudo --nosignature --nodigest --qf \'%{VERSION}\'') | |||
| elsif Facter::Util::Resolution.which('sudo') and Facter::Util::Resolution.which('awk') | |||
|
On OpenBSD, there is no package I can query the version from. It's part of the base installation, same is true with awk. I do the Facter::Util::Resolution::which test for sudo and awk, because when someone doesn't have rpm installed, to prevent that one, to run the exec to figure out the version, and potentially throw an error. |
and enhance the fact about the sudo version to work on non-rpm based systems, at least OpenBSD tested.
|
rebased for your convenience, build failures seem due to github failure |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch below adds support for OpenBSD.
The sudoers file is taken from a -current OpenBSD system, with just the added
includedir /etc/sudoers.d
statement.
Further changes to params.pp for OpenBSD support, mostly copied from freebsd.
The little change to package.pp was necessary, because sudo is part of the base installation, therefore no package needed to be installed.