Optimization the base _filter_seen method
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkey0head
requested changes
Mar 22, 2023
| @@ -457,33 +456,6 @@ def _filter_seen( | |||
| """ | |||
| users_log = log.join(users, on="user_idx") | |||
| self._cache_model_temp_view(users_log, "filter_seen_users_log") | |||
| num_seen = users_log.groupBy("user_idx").agg( | |||
There was a problem hiding this comment.
t seems those steps are not redundant.
some models (a lot of models) do not filter seen items inside _predict(). So if we want to predict with filter_seen_items=True, we
- predict more items than needed (k + max_seen),
- filter out seed items (thus we will get number of recommendations in interval [k, k + max_seen]
- get top-k most relevant
So, ether you placed seen filtering inside _predict method of each model and it is not in the current pr, or you just removed some necessary functionality. Lets discuss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant steps in base
_filter_seenmethod.