Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce docker image size #66

Merged
merged 2 commits into from
Jun 14, 2024
Merged

reduce docker image size #66

merged 2 commits into from
Jun 14, 2024

Conversation

LTS42
Copy link
Contributor

@LTS42 LTS42 commented May 30, 2024

Dockerfile was not efficient.
This makes it smaller.
Tested to see the result is the same.

With original dockerfile, it would take about 600 seconds on M2.
With the new dockerfile, it takes about 70 seconds.

@sb2nov
Copy link
Owner

sb2nov commented Jun 14, 2024

Thanks -- It conflicts with your other PR - could you resolve the conflict?

@1993CRV
Copy link
Contributor

1993CRV commented Jun 14, 2024

@LTS42 @sb2nov thoughts on using Alpine instead of Debian and Ubuntu? it's only 5 MB

https://hub.docker.com/_/alpine

Comparison:

Image Compressed Size (MB)
Ubuntu Xenial 16.04 44.35
Ubuntu Noble 24.04 27.53
Debian Stable Slim 27.8
Alpine 3.45

@sb2nov
Copy link
Owner

sb2nov commented Jun 14, 2024

I'm supportive - do you want to send a PR ?

@LTS42
Copy link
Contributor Author

LTS42 commented Jun 14, 2024

@LTS42 @sb2nov thoughts on using Alpine instead of Debian and Ubuntu? it's only 5 MB

https://hub.docker.com/_/alpine

alpine will end up taking more time because of how bare bone it is (I tried).
by using debian:stable-slim, we are effectively offloading essential build time to download time which in most cases will be faster.
if you are able to come up with a branch, I can test it on my machine how long it takes (or you can, with this branch and your new branch).
for now, I'm resolving and merging (with approval)

@sb2nov sb2nov merged commit 3fb875f into sb2nov:master Jun 14, 2024
1 check failed
@sb2nov
Copy link
Owner

sb2nov commented Jun 14, 2024

Merged this and we can try to move to alpine in a followup if we make it work but this is already way better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants