Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skypath moon #67

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Skypath moon #67

wants to merge 6 commits into from

Conversation

sbailey
Copy link
Owner

@sbailey sbailey commented May 6, 2019

Trying new PR. @rdoshi99 does this contain all the commits it should?

@rdoshi99
Copy link
Collaborator

Yeah, this looks right. I am adding a comment with the description of the PR

@rdoshi99
Copy link
Collaborator

Created a sine function to approximate the phase of the moon through the getPhase function

helper functions include:
phaseSign which determines if the moon phase is waxing waning
toDatetime which converts a night into a datetime object (perhaps this function should be merged)
numNightsFullZero (which calculates the number of days which have passed since a specific full moon on Nov. 11, 2019)
getWedge which, given the phase of the moon, plots a point onto the figure (from skypath plot) as either a ring, wedge, or full circle depending on the phase of the moon

This also adds a label to the top of the skypath plot with the fraction of the moon illuminated

This addresses issue #27

and the attached image shows the model with rough approximations from hand calculations
https://user-images.githubusercontent.com/46800082/56942231-55fd9480-6ace-11e9-95ba-3dca439181c0.png

@rdoshi99
Copy link
Collaborator

The other comment I have is that I added the label for moon fraction but I could not get it to align right on the plot:
https://user-images.githubusercontent.com/46800082/56942266-90673180-6ace-11e9-8beb-9405d3798ceb.png
This is because the Label annotation on bokeh doesn't support the same type of align as Title does
I tried adding a second Title and this was the result:
https://user-images.githubusercontent.com/46800082/56942293-b7256800-6ace-11e9-803e-27ff6cad2cd3.png
Where the actual plot title gets pushed up farther above, which I thought would mess with the styling already done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants