-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skypath moon #67
base: master
Are you sure you want to change the base?
Skypath moon #67
Conversation
Yeah, this looks right. I am adding a comment with the description of the PR |
Created a sine function to approximate the phase of the moon through the getPhase function helper functions include: This also adds a label to the top of the skypath plot with the fraction of the moon illuminated This addresses issue #27 and the attached image shows the model with rough approximations from hand calculations |
The other comment I have is that I added the label for moon fraction but I could not get it to align right on the plot: |
Trying new PR. @rdoshi99 does this contain all the commits it should?