feat: add 'now' property instead of data-now attribute #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideMininni-Fincons
requested review from
kyubisation and
jeripeierSBB
as code owners
github-actions
bot
added
the
pr: peer review required
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
jeripeierSBB
requested changes
May 23, 2024
TomMenga
requested changes
May 23, 2024
src/components/datepicker/datepicker-toggle/datepicker-toggle.ts
Outdated
Show resolved
Hide resolved
TomMenga
requested changes
May 24, 2024
src/components/datepicker/datepicker-toggle/datepicker-toggle.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # src/elements-experimental/journey-summary/journey-summary.ts # src/elements-experimental/pearl-chain-time/pearl-chain-time.ts # src/elements-experimental/pearl-chain/pearl-chain.ts # src/elements-experimental/timetable-row/timetable-row.ts # src/elements/core/datetime/data-now.ts # src/elements/core/mixins/now-mixin.ts
github-actions
bot
added
the
pr: lead review approved
github-actions
bot
removed
the
pr: peer review required
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2654
BREAKING CHANGE: The half-public data-now attribute has become a public
nowproperty that can be used to set time or date-based components into a specific state, especially for testing purposes.sbb-calendar,sbb-datepicker,sbb-timetable-row,sbb-journey-summary,sbb-pearl-chain,sbb-pearl-chain-time: change the attributedata-nowtonow. The propertynowcan be a Date or Unix timestamp. Just so you know, if you had a timestamp in milliseconds before, please divide by 1000 to get seconds.sbb-clock: change the attributedata-nowtonow. The propertynowhas to be in the format "HH:MM:SS".