-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sbb-tab): align with sbb-stepper #2744
Conversation
…th-stepper # Conflicts: # src/elements/tabs/tab-group/tab-group.e2e.ts # src/elements/tabs/tab-group/tab-group.spec.ts # src/elements/tabs/tab-label/__snapshots__/tab-label.spec.snap.js # src/elements/tabs/tab-label/__snapshots__/tab-title.snapshot.spec.snap.js # src/elements/tabs/tab-label/tab-title.snapshot.spec.ts # src/elements/tabs/tab-title/__snapshots__/tab-title.spec.snap.js # src/elements/tabs/tab-title/tab-title.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far! I think also in terms of implementation there could be improvements to the previous version, but you covered the breaking changes, so probably for now it's should be ok :-).
…th-stepper # Conflicts: # src/elements/tabs/tab-group/tab-group.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Preflight Checklist
Issue
This PR Closes #2240 #1351
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
sbb-tab-title
has been renamedsbb-tab-label
to align the naming with the stepper;sbb-tab
has been added; the content of a single tab within the tab group must be included in this new component (article, section and div are not supported anymore);sbb-tab
has the logic to retrieve the related labeldidChange
event now emits an object which contains the current (and previous, if available) tab index, tab label and tab content.Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
BREAKING CHANGE
sbb-tab-title
has been renamed tosbb-tab-label
;sbb-tab
; article, section and div are not supported anymore;didChange
event onsbb-tab-group
now includes an object which contains the currently selected tab index,sbb-tab-label
andsbb-tab
, and, if available, the previous ones.Other information