-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: n2k response in clear & silence Notification #5
Conversation
index.js
Outdated
existing.method = method | ||
|
||
var existing = app.getSelfPath(npath) | ||
if (typeof existing.value === 'undefined') existing.value = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right. Should not be an array. Following statements will fail. I think if it's undefined just return, nothing to do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a problem
index.js
Outdated
|
||
existing.timestamp = (new Date()).toISOString() | ||
|
||
const delta = { | ||
context: "vessels." + app.selfId, | ||
updates: [ | ||
{ | ||
source: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you setting source? Not sure this will even get through?
No description provided.