Fallback cold #96
Merged
Fallback cold #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # replay/models/base_rec.py # replay/models/base_torch_rec.py # replay/scenarios/two_stages/two_stages_scenario.py
# Conflicts: # tests/utils.py
# Conflicts: # replay/models/base_rec.py # replay/scenarios/two_stages/two_stages_scenario.py # tests/test_save_load.py
# Conflicts: # replay/models/base_rec.py # replay/models/lightfm_wrap.py # replay/models/pop_rec.py # replay/scenarios/fallback.py
|
max_user max_item is now real maximal idx of user/item (no + 1) |
AleXXL1986
suggested changes
Feb 16, 2022
replay/models/base_rec.py
Outdated
|
|
||
| @property | ||
| def max_item(self) -> int: | ||
| """ | ||
| :returns: number of items the model was trained on | ||
| :returns: maximum item_idx presented in the models' train dataset |
replay/models/admm_slim.py
Outdated
| @@ -128,17 +128,17 @@ def _fit( | |||
| pandas_log["relevance"], | |||
| (pandas_log["user_idx"], pandas_log["item_idx"]), | |||
| ), | |||
| shape=(self.max_user, self.max_item), | |||
| shape=(self.max_user + 1, self.max_item + 1), | |||
There was a problem hiding this comment.
pls add one inside max_user/item (possible you need rename this property to another name)
|
AleXXL1986
approved these changes
Feb 17, 2022
This was referenced Feb 17, 2022
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.