Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve coordinate parsing (no SIMD) #13

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

sbernauer
Copy link
Owner

CC @fabi321

parse_draw_commands_ordered/1920 x 1080
                        time:   [25.165 ms 25.224 ms 25.285 ms]
                        change: [-2.5271% -0.9256% +0.1508%] (p = 0.22 > 0.05)
                        No change in performance detected.

parse_draw_commands_shuffled/1920 x 1080
                        time:   [31.482 ms 31.761 ms 32.174 ms]
                        change: [-4.3100% -3.1584% -1.6421%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
  4 (4.00%) high severe

@sbernauer sbernauer merged commit 8680fb1 into master Jun 19, 2023
8 checks passed
@fabi321
Copy link
Contributor

fabi321 commented Jun 20, 2023

I just ran it, and

parse_draw_commands_ordered/1920 x 1080
                        time:   [9.9544 ms 9.9836 ms 10.014 ms]
                        change: [-9.6493% -9.3275% -9.0247%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

parse_draw_commands_shuffled/1920 x 1080
                        time:   [18.163 ms 18.240 ms 18.322 ms]
                        change: [-2.8521% -2.3694% -1.8999%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  4 (4.00%) high mild
  4 (4.00%) high severe

Entirely skipped 10ms. My results have been in the low 11ms before.

@sbernauer
Copy link
Owner Author

Awesome, good to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants