Fix missing content view in action sheet #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I expected travis to fail the test, but it seems you UI tests are not included into travis |
|
OK, seems bug was introduced in 88c0654, so it was an easy fix. However, view seems to have no padding now and I'm not sure if this good or bad. On one side, now it's fully controlled by user (no extra padding), but it's not backward compatible since the commit I mentioned |
|
Ah, and it also somehow got invisible to the accessibility layer, so invisible to my test too 😞 |
ReDetection
changed the title
|
Thanks for submitting. I'll try to find some time soon to look at this. |
|
Looks great, thanks for submitting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #261