Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sheet alert crash on ipad #307

Conversation

lechuckcaptain
Copy link

Fix #306

* Test modal window opened in fullscreen to avoid detection conflicts
* Added accessibilityIdentifier for SDCAlertController and embedded alert view
* Aligned test 11 with actual implementation
@@ -324,6 +325,9 @@ public final class AlertController: UIViewController {
}

self.alert.layoutIfNeeded()

self.view.accessibilityIdentifier = type(of: self).description()
self.alert.accessibilityIdentifier = type(of: self.alert).description()
Copy link
Owner

@sberrevoets sberrevoets Jun 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem irrelevant. If they represent some other type of bug, can you please open a separate ticket/PR?

Copy link
Owner

@sberrevoets sberrevoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting, this is good to go with the irrelevant changes reverted

@sberrevoets
Copy link
Owner

Closing this for inactivity, feel free to reopen!

@sberrevoets sberrevoets closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example app crash on iPad presenting UIAlertController
2 participants