Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to unit tests #23

Closed
psteinb opened this issue Nov 5, 2021 · 1 comment · Fixed by #29
Closed

Improvements to unit tests #23

psteinb opened this issue Nov 5, 2021 · 1 comment · Fixed by #29
Assignees
Labels
enhancement New feature or request

Comments

@psteinb
Copy link
Contributor

psteinb commented Nov 5, 2021

While running into sbi API problems (see #21) I ran some unit tests locally on my laptop (mostly as a sanity check). This revealed very quickly that the unit tests, e.g. under algorithms, are geared towards correctness of results rather than correctness of API usage. I suspect that this is also the reason why this repo doesn't use CI facilities like github-actions.

While I value correctness of results very highly, the correctness of API is a precondition. If the code breaks before a result can be obtained, there will be no result to test for correctness. ;-) It might be worthwhile to introduce faster and slower tests (similar to what sbi does).

@jan-matthis
Copy link
Contributor

jan-matthis commented Nov 8, 2021

Speed of the tests was one reason why I did not set them up on CI, but mostly I just post-poned it to the future, when we have more collaborators/the codebase is growing :)

Since this is the case now, I'll go through the tests, mark some as slow, and set things up on GH actions.

@jan-matthis jan-matthis changed the title fast(er) unit tests Improvements to unit tests Nov 8, 2021
@jan-matthis jan-matthis added the enhancement New feature or request label Nov 8, 2021
@jan-matthis jan-matthis linked a pull request Nov 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants