-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1D marginals #600
1D marginals #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this, looks great!
I added some comments about black
and isort
and I have two high level comments / questions: 1) why do we separate the code into the analysis module and the utils module? 2) we now have a lot of code repetition between marginal_plot
and pairplot
, e.g., how the limits are set up, how the diag_fun
is built. Whenever there is such a repetition I think it makes sense to outsource the code to a function, which is then called by pairplot
and marginal_plot
, i.e., a function get_limits(samples...)
and a function get_diag_fun(samples...) -> Callable
.
Let's discuss this later in the meeting.
Codecov Report
@@ Coverage Diff @@
## main #600 +/- ##
==========================================
- Coverage 66.94% 66.67% -0.28%
==========================================
Files 67 66 -1
Lines 4251 4267 +16
==========================================
- Hits 2846 2845 -1
- Misses 1405 1422 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Everything is added and refactored now - only question is do we want the keywords passed to 1D marginal plots to keep the "diag" terminology for consistency, or change it to something like "col"? Also need to add some comments to new functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! I added small comments and it needs a rebase on main to resolve some small conflicts.
Added functions to plot just the 1D marginals. Using same interface as pairplot functions.