Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom prior support #602

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Fix custom prior support #602

merged 3 commits into from
Jan 27, 2022

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jan 25, 2022 •
edited

  • add validate_args and support to the custom prior wrapper.
  • allow the user to pass upper and lower bound kwargs for priors with bounded support.

fixes #581

relates to #595

@janfb janfb self-assigned this Jan 25, 2022
michaeldeistler
michaeldeistler reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great, thanks a lot! I left some comments below.

sbi/utils/user_input_checks.py Outdated Show resolved Hide resolved
sbi/utils/user_input_checks.py Show resolved Hide resolved
sbi/utils/user_input_checks.py Show resolved Hide resolved
sbi/utils/user_input_checks.py Show resolved Hide resolved
sbi/utils/user_input_checks_utils.py Outdated Show resolved Hide resolved
sbi/utils/user_input_checks_utils.py Outdated Show resolved Hide resolved
sbi/utils/user_input_checks_utils.py Outdated Show resolved Hide resolved
sbi/utils/user_input_checks_utils.py Show resolved Hide resolved
@janfb janfb mentioned this pull request Jan 26, 2022
Closed
@janfb janfb mentioned this pull request Jan 27, 2022
Closed
michaeldeistler
michaeldeistler approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great now, I think the API is fantastic. And great that it works with Uniform and custom priors now! Thanks a lot!

@janfb janfb merged commit 93f64dc into main Jan 27, 2022
@janfb janfb deleted the fix-custom-prior-support branch January 27, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler approved these changes

Assignees

@janfb janfb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom prior
2 participants
@janfb @michaeldeistler