perform sir in untransformed space to fix #634. #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
requested changes
Feb 11, 2022
janfb
force-pushed
the
fix-634
branch
2 times, most recently
from
0a90e3c
to
ee05900
Compare
michaeldeistler
requested changes
Feb 11, 2022
michaeldeistler
approved these changes
Feb 11, 2022
janfb
changed the title
Codecov Report
@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 74.55% 74.81% +0.26%
==========================================
Files 75 75
Lines 5668 5667 -1
==========================================
+ Hits 4226 4240 +14
+ Misses 1442 1427 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #634
not sure why exactly this failed only for the
MultipleIndependentprior. Isn't thesirsupposed to use the transformed potential in any case, i.e., isn't this a general bug? @michaeldeistler