-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General code quality fixes #92
Conversation
@akx awesome changes!! Thank you! |
@all-contributors please add @akx code |
I've put up a pull request to add @akx! 🎉 |
@sbidy Thank you! Sure - those breaking changes could be done in the next semver-major update (0.5.x or 0.6.x maybe?). Can you approve GH workflows for this PR (first-time contributors need approval) so I can see if there's anything that needs changes lint-wise? |
@sbidy I rebased this and fixed the issues that occurred in CI, but I had to edit the workflow file to do so, so you'll need to re-approve :) |
Yes, hopefully I can get my hands on the PR to merge this in the next days. |
This PR applies a bunch of general code quality & typing fixes. In that, it may fix some future or corner-case bugs.
👉 I would strongly advise this PR not be squash-merged in case trouble arises down the line; it would make it a lot easier to bisect (not to mention
git annotate
s look better).In particular:
mypy --strict
now passes fully for the codebaseSome future improvements might include:
Of course please let me know if you want this e.g. split into multiple PRs, or if there's any concerns :)