Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use asyncio.Protocol/asyncio.DatagramTransport directly #99

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Use asyncio.Protocol/asyncio.DatagramTransport directly #99

merged 1 commit into from
Feb 6, 2022

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Feb 5, 2022

  • Fixes log spam when the device is online

@bdraco bdraco force-pushed the protocol branch 3 times, most recently from d5afea4 to 1035ec8 Compare February 5, 2022 21:31
@bdraco bdraco marked this pull request as ready for review February 5, 2022 21:39
@bdraco
Copy link
Contributor Author

bdraco commented Feb 5, 2022

@sbidy This should take care of the chatty logs when the device is offline

2022-02-05 15:39:02 ERROR (MainThread) [homeassistant.components.wiz] Error fetching WiZ Dimmable White 2034FD data: Failed to update device at 192.168.214.86: The request to the bulb timed out
2022-02-05 15:39:46 INFO (MainThread) [homeassistant.components.wiz] Fetching WiZ Socket 9C1599 data recovered

@bdraco bdraco mentioned this pull request Feb 5, 2022
Merged
22 tasks
bdraco added a commit to bdraco/home-assistant that referenced this pull request Feb 5, 2022
@bdraco
Fix Task exception was never retrieved when WiZ devices are offline
0822747 
- Requires upstream PR: sbidy/pywizlight#99
@bdraco bdraco mentioned this pull request Feb 5, 2022
Merged
22 tasks
@bdraco bdraco force-pushed the protocol branch 2 times, most recently from f97d17e to 641c0ea Compare February 5, 2022 21:57
bdraco
bdraco commented Feb 5, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bdraco bdraco closed this Feb 5, 2022
@bdraco bdraco reopened this Feb 5, 2022
@bdraco
Copy link
Contributor Author

bdraco commented Feb 5, 2022

Looks like github is being flakey as I pushed a few more commits but they aren't showing

@bdraco bdraco force-pushed the protocol branch 3 times, most recently from 2c482be to cd69e77 Compare February 5, 2022 22:52
@bdraco
Use asyncio.Protocol/asyncio.DatagramTransport directly
430cb79 
- Fixes log spam when the device is online
@bdraco
Copy link
Contributor Author

bdraco commented Feb 5, 2022

Force pushing it got github to catch up

@sbidy sbidy merged commit 60a59f2 into sbidy:master Feb 6, 2022
@sbidy
Copy link
Owner

sbidy commented Feb 6, 2022

@all-contributors please add @bdraco code

@allcontributors allcontributors bot mentioned this pull request Feb 6, 2022
Merged
@allcontributors
Copy link
Contributor

@sbidy

I've put up a pull request to add @bdraco! 🎉

@bdraco
Copy link
Contributor Author

bdraco commented Feb 6, 2022

Thanks @sbidy 👍

@fabaff fabaff mentioned this pull request Oct 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdraco @sbidy