Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize some code #231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions example/lib/trimmer_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,7 @@ class _TrimmerViewState extends State<TrimmerView> {
Widget build(BuildContext context) {
return WillPopScope(
onWillPop: () async {
if (Navigator.of(context).userGestureInProgress) {
return false;
} else {
return true;
}
return !Navigator.of(context).userGestureInProgress;
},
child: Scaffold(
backgroundColor: Colors.black,
Expand Down
68 changes: 48 additions & 20 deletions lib/src/trim_viewer/trim_viewer.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
import 'dart:async';
import 'dart:developer';

import 'package:flutter/material.dart';
import 'package:video_trimmer/video_trimmer.dart';

Expand Down Expand Up @@ -192,11 +195,16 @@ class TrimViewer extends StatefulWidget {

class _TrimViewerState extends State<TrimViewer> with TickerProviderStateMixin {
bool? _isScrollableAllowed;
late StreamSubscription<TrimmerEvent> _eventSubscription;

@override
void initState() {
super.initState();
widget.trimmer.eventStream.listen((event) {
_init();
}

void _init() {
_eventSubscription = widget.trimmer.eventStream.listen((event) {
if (event == TrimmerEvent.initialized) {
final totalDuration =
widget.trimmer.videoPlayerController!.value.duration;
Expand All @@ -218,9 +226,37 @@ class _TrimViewerState extends State<TrimViewer> with TickerProviderStateMixin {
});
}

@override
void didUpdateWidget(covariant TrimViewer oldWidget) {
if (oldWidget.trimmer != widget.trimmer) {
_eventSubscription.cancel();
_init();
}
super.didUpdateWidget(oldWidget);
log("TrimViewer didUpdateWidget");
}

@override
void dispose() {
_eventSubscription.cancel();
super.dispose();
}

@override
Widget build(BuildContext context) {
final scrollableViewer = ScrollableTrimViewer(
if (_isScrollableAllowed == null) {
return const SizedBox();
}

if (widget.type == ViewerType.scrollable || _isScrollableAllowed == true) {
return _buildScrollableTrimViewer();
}

return _buildFixedTrimViewer();
}

Widget _buildFixedTrimViewer() {
return FixedTrimViewer(
trimmer: widget.trimmer,
maxVideoLength: widget.maxVideoLength,
viewerWidth: widget.viewerWidth,
Expand All @@ -231,17 +267,22 @@ class _TrimViewerState extends State<TrimViewer> with TickerProviderStateMixin {
onChangeStart: widget.onChangeStart,
onChangeEnd: widget.onChangeEnd,
onChangePlaybackState: widget.onChangePlaybackState,
paddingFraction: widget.paddingFraction,
editorProperties: widget.editorProperties,
areaProperties: widget.areaProperties,
areaProperties: FixedTrimAreaProperties(
thumbnailFit: widget.areaProperties.thumbnailFit,
thumbnailQuality: widget.areaProperties.thumbnailQuality,
borderRadius: widget.areaProperties.borderRadius,
),
onThumbnailLoadingComplete: () {
if (widget.onThumbnailLoadingComplete != null) {
widget.onThumbnailLoadingComplete!();
}
},
);
}

final fixedTrimViewer = FixedTrimViewer(
Widget _buildScrollableTrimViewer() {
return ScrollableTrimViewer(
trimmer: widget.trimmer,
maxVideoLength: widget.maxVideoLength,
viewerWidth: widget.viewerWidth,
Expand All @@ -252,27 +293,14 @@ class _TrimViewerState extends State<TrimViewer> with TickerProviderStateMixin {
onChangeStart: widget.onChangeStart,
onChangeEnd: widget.onChangeEnd,
onChangePlaybackState: widget.onChangePlaybackState,
paddingFraction: widget.paddingFraction,
editorProperties: widget.editorProperties,
areaProperties: FixedTrimAreaProperties(
thumbnailFit: widget.areaProperties.thumbnailFit,
thumbnailQuality: widget.areaProperties.thumbnailQuality,
borderRadius: widget.areaProperties.borderRadius,
),
areaProperties: widget.areaProperties,
onThumbnailLoadingComplete: () {
if (widget.onThumbnailLoadingComplete != null) {
widget.onThumbnailLoadingComplete!();
}
},
);

return _isScrollableAllowed == null
? const SizedBox()
: widget.type == ViewerType.fixed
? fixedTrimViewer
: widget.type == ViewerType.scrollable
? scrollableViewer
: _isScrollableAllowed == true
? scrollableViewer
: fixedTrimViewer;
}
}