working with RC 1.3, 1.2, 1.X and 0.9 by deprecating the rcmail usage #26
Conversation
mckaygerhard
commented
Jan 1, 2020
mckaygerhard
commented
- hopes fixed RC 1.3.4 with automatic_addressbook #20
There was a problem hiding this comment.
Thank you for your PR.
I don't understand very well why you want to replace rcmail by rcube.
I just tested the plugin with RC 1.4.2 and it works pretty well like this.
Can you point me to a deprecation or removal notice somewhere in roundcube code or mailing list ?
| @@ -1,3 +1,6 @@ | |||
| v0.5 : | |||
There was a problem hiding this comment.
Please do not include version release information in your PR as you don't know how it will be named (could be 1.0 or 0.4.1). Prefere using unreleased: here, I will name it when releasing.
There was a problem hiding this comment.
well there's no problem! always you can override by a new commit by yourselft.. that's all
|
|
||
| automatic_addressbook plugin version 0.2 has been tester against roundcube 0.5 and 0.6. | ||
| above versions have been tested against roundcube 0.8.0 and 0.8.1 with larry skin and mysql backend. | ||
| automatic_addressbook plugin version 0.2 has been tester against roundcube 0.9 |
There was a problem hiding this comment.
tester -> tested.
Please do not update this one concerning automatic_addressbook v0.2 (an old version) or remove it completely
There was a problem hiding this comment.
as i said.. can you merged and later just updated by yourselft? can you explain me more in detail?
| -------------------------- | ||
|
|
||
| you must use files before commit ca622de3364b996c655eea2e7724ce6e325e9b9d for older versions. |
There was a problem hiding this comment.
Prefer reference to plugin version rather than commit id
There was a problem hiding this comment.
i used commit due that commit included some changes! lasted older version still have minor issues that i'm working on
