Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when computing the transfer matrix with remeshing #244

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Jun 6, 2023

This PR merges a fix for computing the transfer matrix. This was not done correctly when the geometry was remeshed multiple times.

@sblauth sblauth added the bug Something isn't working label Jun 6, 2023
@sblauth sblauth self-assigned this Jun 6, 2023
@sblauth sblauth enabled auto-merge June 6, 2023 07:50
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #244 (ea9e14e) into main (ce07e8e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   92.62%   92.63%           
=======================================
  Files          83       83           
  Lines        6426     6430    +4     
=======================================
+ Hits         5952     5956    +4     
  Misses        474      474           
Impacted Files Coverage Δ
cashocs/_database/database.py 100.00% <100.00%> (ø)
cashocs/_database/geometry_database.py 100.00% <100.00%> (ø)
cashocs/_optimization/line_search/line_search.py 100.00% <100.00%> (ø)
cashocs/geometry/mesh_handler.py 93.73% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sblauth sblauth merged commit 091014c into main Jun 6, 2023
20 of 22 checks passed
@sblauth sblauth deleted the hotfix/2.0.2 branch June 6, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant