Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration file parameter [LineSearch][fail_if_not_converged] #245

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Jun 6, 2023

This parameter determines, whether the line search is cancelled once the state system cannot be solved at a (trial) iterate. If this is True, then the line search is cancelled. Otherwise, the step size is "halved" and a new iterate is generated.

This parameter determines, whether the line search is cancelled once the
state system cannot be solved at a (trial) iterate. If this is True, then
the line search is cancelled. Otherwise, the step size is "halved" and a
new iterate is generated.
@sblauth sblauth added the enhancement New feature or request label Jun 6, 2023
@sblauth sblauth added this to the v2.1 milestone Jun 6, 2023
@sblauth sblauth self-assigned this Jun 6, 2023
@sblauth sblauth enabled auto-merge June 6, 2023 08:32
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #245 (d3c9713) into main (091014c) will decrease coverage by 0.05%.
The diff coverage is 63.64%.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   92.63%   92.58%   -0.05%     
==========================================
  Files          83       83              
  Lines        6430     6439       +9     
==========================================
+ Hits         5956     5961       +5     
- Misses        474      478       +4     
Impacted Files Coverage Δ
cashocs/io/config.py 100.00% <ø> (ø)
...cs/_optimization/line_search/armijo_line_search.py 92.65% <63.64%> (-5.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sblauth sblauth merged commit 9ae6600 into main Jun 6, 2023
22 checks passed
@sblauth sblauth deleted the feature/fail_if_not_converged branch June 6, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant